Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement propagators #110

Closed
bshi opened this issue Oct 27, 2020 · 4 comments · Fixed by #200
Closed

Implement propagators #110

bshi opened this issue Oct 27, 2020 · 4 comments · Fixed by #200
Labels

Comments

@bshi
Copy link

bshi commented Oct 27, 2020

Presently, trace context via HTTP header X-Cloud-Trace-Context (or the equivalent gRPC header) doesn't appear to be extracted from inbound requests.

OpenCensus equivalent: https://pkg.go.dev/go.opencensus.io/exporter/stackdriver/propagation

https://pkg.go.dev/go.opentelemetry.io/otel/propagators

@glassonion1
Copy link

glassonion1 commented Dec 9, 2020

I also agree.
However, I thought that it should be implemented in open-telemetry-go-contrib instead of exporter.

I tried implementing http propagator in my library below.
https://github.com/glassonion1/logz/blob/main/propagation/http_format.go

@punya
Copy link
Contributor

punya commented Feb 1, 2021

Related to #116.

@punya punya added the trace label Feb 1, 2021
@punya
Copy link
Contributor

punya commented Apr 14, 2021

Related to census-ecosystem/opencensus-go-exporter-stackdriver#254 -- we should make sure we comply with the v2 spec.

@amammay
Copy link

amammay commented Jun 13, 2021

just so i can have some ease of re-use in some of my own projects i went ahead and created a package based off @glassonion1 implementation with just some slight tweaks to work with open telemetry v0.20.0

https://github.com/amammay/propagationgcp

@ymotongpoo ymotongpoo linked a pull request Jul 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants