From 223cfc83221ff6eb30dd08c413d61afaf674c236 Mon Sep 17 00:00:00 2001 From: Barry Pollard Date: Tue, 15 Oct 2024 20:16:36 +0100 Subject: [PATCH] Review feedback --- README.md | 5 +++-- src/types/inp.ts | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index c29b4944..55c033c1 100644 --- a/README.md +++ b/README.md @@ -864,8 +864,9 @@ interface INPAttribution { /** * The best-guess timestamp of the next paint after the interaction. * In general, this timestamp is the same as the `startTime + duration` of - * the event timing entry. However, due to this being rounded to 8ms it - * can be slightly after that. + * the event timing entry. However, since duration values are rounded to the + * nearest 8ms (and can be rounded down), this value is clamped to always be + * reported after the processing times. */ nextPaintTime: DOMHighResTimeStamp; /** diff --git a/src/types/inp.ts b/src/types/inp.ts index d7d826f9..59b2acc5 100644 --- a/src/types/inp.ts +++ b/src/types/inp.ts @@ -53,8 +53,9 @@ export interface INPAttribution { /** * The best-guess timestamp of the next paint after the interaction. * In general, this timestamp is the same as the `startTime + duration` of - * the event timing entry. However, due to this being rounded to 8ms it - * can be slightly after that. + * the event timing entry. However, since duration values are rounded to the + * nearest 8ms (and can be rounded down), this value is clamped to always be + * reported after the processing times. */ nextPaintTime: DOMHighResTimeStamp; /**