-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about the acceptable sequence length of borzoi #72
Comments
Hi @HelloWorldLTY , that doesn't sound right, our borzoi model should also take 524 kb input. Please see tutorial 1 where we use the model to make predictions on a 524 bp long sequence. Could you clarify where you found the number 512? |
This is because 'BorzoiPretrainedModel' is not the same thing as the actual Borzoi model. To load the actual Borzoi model with the architecture and weights trained by Linder et al., please follow the instructions in tutorial 1. What you are doing here, with |
Correct me if i'm wrong, but specifying If then i follow up with Please correct me if my understanding isn't right. Best, |
I am also a bit confsed here.
It seems that BorzoiPretrainedModel will give us an identical model. I think what Avantikalal want to say is that this function changed the output header and thus the output will be different. I think you do not need to fix the other weights unless you really want. It will be better if you finetune all weights together. |
@HelloWorldLTY I agree with you. It's just that i'm finetuning with a small sample size, therefore i fear that i might make it overfit if i update all the weights. I'm testing out both by the way to see if that's the case |
@HelloWorldLTY @AndreaMariani-AM, the Borzoi model consists of convolutional / transformer layers followed by a linear 'head' layer that gives you the correct number of output tracks. If you load the Borzoi model from the model zoo using If you use the I hope this clarifies. We're aware that this is an unnecessary and confusing system with two ways to do the same thing, and will soon change it (#58). Therefore, I recommend using |
Perfect! Thanks for the explanation. It makes absolute sense for me! Best, |
Hi, I notice that the borzoi model of gReLU relies on 512 as input sequence length, which is different from the default setting of borzoi (https://www.biorxiv.org/content/10.1101/2023.08.30.555582v1.full.pdf) should be 524 kb.
Thanks a lot.
The text was updated successfully, but these errors were encountered: