Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.12] Class rename handling of methods that refer to its class directly #974

Open
LisaAlmarode opened this issue Nov 17, 2022 · 0 comments
Assignees

Comments

@LisaAlmarode
Copy link
Member

Given the class RenameTest with the following methods:

myOwnClass
^RenameTest
RenameTest
^self class
test
^self RenameTest

If you rename the class RenameTest to NewName, the method myOwnClass fails compile, since the older class name isn't there (dialog needs some work, too).
Somehow, it cancels the rename and you can edit your method so it will recompile (say, add # to the className so it's a symbol), and a subsequent rename will succeed, and you can edit that method again to refer to the new class by name.

(note that my image got into a state where the second rename was throwing some ugly errors, but it cleared up and does not reproduce).

This issue to make rename work in this scenario; that is not required for first release.

More testing would be nice, to see if the ugly dialogs can be reproduced. I think I'd earlier done an abort after a rename, but that didn't help reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants