Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For GemStone support we need to be able to specify a file encoding and StringClass ala topaz #75

Closed
dalehenrich opened this issue Dec 6, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dalehenrich
Copy link
Member

dalehenrich commented Dec 6, 2022

topaz has the following commands that we'll need to be able to replicate when using FileSystem streams:

FILEFORMAT UTF8 | 8BIT
set sourcestringclass String | Unicode16

8BIT encoding will encode the input as 8Bit ASCII and return results as instances of String only.

UTF8 encoding is already supported by FileSystemGs, however, the UTF8 encoder returns instances of String, DoubleByteString, and QuadByteString. We also need to support a variant of the UTF8 encoder that returns instances of Unicode7, Unicode16, or Unicode32.

@dalehenrich dalehenrich added the enhancement New feature or request label Dec 6, 2022
@dalehenrich dalehenrich self-assigned this Dec 6, 2022
dalehenrich added a commit that referenced this issue Dec 12, 2022
…aracterReadStream and ZnCharacterReadWriteStream, needed to allow end user to choose between Unicode and Legacy stream flavors
dalehenrich added a commit that referenced this issue Dec 12, 2022
…Tests so we can test ZnCharacterStream with Unicode7 and String stringClass
dalehenrich added a commit that referenced this issue Dec 13, 2022
…issues; testUpTo and testUpToAll tests are still not passing
dalehenrich added a commit that referenced this issue Dec 14, 2022
…reamTests and ZnLegacyCharacterStreamTests: testUpToAll, testUpToAllTwice and testUtf8EncodingStreamPositionFor...) are all apparently due to Issue #80
@dalehenrich
Copy link
Member Author

These failing tests:
Screenshot from 2022-12-14 09-17-37
Screenshot from 2022-12-14 09-17-59
are all (presumably) due to issue #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants