FileSystem Development Target

[kurtkilpela]

We do not have a defined target version for FileSystem. I suggest we set our target compatibility w/ Pharo 10's FileSystem implementation.

The specific set of classes which should be compatible with this target version should be defined. The implementation used to support them can (and will) differ.

[kurtkilpela]

GemStone incorporated the classes InteractiveResolver and ResolutionRequest due to their presence in Pharo. I don't believe we should include these in our set of supported classes. GemStone does not have a UI and semantically, these classes are designed to interact with the user. They should be removed.

[kurtkilpela]

InteractiveResolver was removed in f601208.

[kurtkilpela]

I consider the following classes to be the public classes for FileSystem. GemStone should provide the following. Note, it may not provide every method the Pharo version does. Methods will be evaluated on a case-by-case basis.

• AbstractFileReference
  • FileLocator
  • FileReference
• FileSystem
• FileSystemResolver
  • PlatformResolver
    • MacOSResolver
    • UnixResolver
  • SystemResolver
• FileSystemError
  • DirectoryDoesNotExist
  • DirectoryExists
  • DirectoryIsNotEmpty
  • FileExists
  • IllegalName
• FileSystemPermission
• DiskStore
  • UnixStore
  • MemoryStore
• Path
  • AbsolutePath
  • RelativePath

[kurtkilpela]

Initial documentation now available in the repo's documentation folder. See 3ef90a5

[kurtkilpela]

I'm not sure I see the need for us to include OSPlatform. In Pharo, OSPlatform is used to get the string version of the Path to the current working directory. Outside of that, there is no reference. This call is made from DiskStore. In our implementation, we call the C Library from DiskStore directly. For GemStone, OSPlatform holds onto the instances of the C Libraries. It seems they'd be better off moved to DiskStore, the main place they are used.

Is there a reason to include OSPlatform that I'm not aware of?

[kurtkilpela]

FileSystem classes no longer directly references OSPlatform in cb1b5ec. OSPlatform remains... for now.

[kurtkilpela]

OSPlatform was removed in 5732286.

[kurtkilpela]

Read-only DiskStore is a low-priority feature. See #59

[kurtkilpela]

FileReference work in #60

[kurtkilpela]

We seem to be fairly in alignment w/ Pharo 10 based upon a review of the classes listed above. There are deviations due to implementation differences or concepts that do not map (like #image).