Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments #113

Open
2 tasks
kurtkilpela opened this issue Feb 23, 2023 · 2 comments
Open
2 tasks

Add comments #113

kurtkilpela opened this issue Feb 23, 2023 · 2 comments
Assignees
@kurtkilpela

Comments

@kurtkilpela
Copy link
Member

kurtkilpela commented Feb 23, 2023 •
edited
Loading

  • FileReference>> openOptions:
  • FsPermissionDenied
@kurtkilpela kurtkilpela self-assigned this Feb 23, 2023
@kurtkilpela kurtkilpela changed the title Add comments to following Add comments Feb 23, 2023
@LisaAlmarode
Copy link
Member

"copy" is unclear if it's an object copy or a copy of an actual file or directory. The following methods should have a method comment for disambiguation:
FileReference >> copyTo: and copyWithPath: Also , (comma operator), which is oddly in navigation unlike its superclass implentation.
AbstractFileReference >> copyWithPath.
FileLocator>>copyWithPath:, , (comma operator) , withoutExtension

The copying category is a little unclear but I think we can't realistically improve it.

@LisaAlmarode
Copy link
Member

FileReference creationTime is (I think) only supported for MemoryStore. If we want to keep it around, it should probably have a comment saying "not currently supported for disk stores"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtkilpela kurtkilpela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kurtkilpela @LisaAlmarode