Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation and assertion for required resource Initialization in latest FSR version #101

Open
PanosK92 opened this issue Oct 9, 2024 · 0 comments

Comments

@PanosK92
Copy link

PanosK92 commented Oct 9, 2024

In the latest version of FSR, the function ffxFsr3UpscalerGetSharedResourceDescriptions must be called to retrieve the necessary resource descriptions, after which the corresponding textures need to be manually created. This step seems to be a new requirement, but it's neither mentioned in the changelog nor documented on GPUOpen.

Context: https://github.com/PanosK92/SpartanEngine/blob/e47b73aadb7a3a9bd14685db7a1e949d3fa8f544/runtime/RHI/Vulkan/Vulkan_FidelityFX.cpp#L734

If you don't do that, and you simply upgrade to the latest FSR, you'll crash. The crash is generic and doesn't provide helpful context. I believe this could be improved in two ways:

  • Documentation update: Please add a note in the changelog or on GPUOpen to inform developers that they must now initialize these resources manually.
  • Runtime assertion: Implement an assert that checks if any of the shared resources are null, clearly indicating that these resources must be initialized. This would clarify the setup requirements for developers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant