When selecting existing license in Activation modal

[LC43]

modal:

When activating a premium license, in the modal, selecting the existing account license, the API returns an error

Uncaught SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

Request:

action | "fs_activate_license_xxxxx"
security | "xxxxxxxxxxxx"
module_id | "xxxxx"
license_key | ""

due to licenseID being set to a number

                licenseID = $availableLicenseKey.data( 'id' );`

then it checks for empty, but will pass since licenseKey.length is true

                if ( 0 === licenseID.length && 0 === licenseKey.length ) {

later, it will check again, and since if fails by checking the lenght of a number ( undefined ), it will try data.license_key = licenseKey, but licenseKey is empty, so the API will get empty values.

                if ( licenseID.length > 0 ) {
                    data.license_id = licenseID;
                } else {
                    data.license_key = licenseKey;
                }

https://github.com/Freemius/wordpress-sdk/blob/cc31279d088909135b6b2d8b4f2696312f5731fc/templates/forms/license-activation.php#L572C62-L572C66

Solution

Either convert it to string, or just check if licenseID !== ''

Versions: (*)

2.8.1