Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designing NodeBuilder v2 API #1793

Open
oxisto opened this issue Oct 18, 2024 · 1 comment
Open

Designing NodeBuilder v2 API #1793

oxisto opened this issue Oct 18, 2024 · 1 comment
Assignees
@oxisto @KuechA
Labels
code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting

Comments

@oxisto
Copy link
Member

oxisto commented Oct 18, 2024

Design principles

  • Remove the necessity for ArgumentHolder / StatementHolder interfaces, since they are bloaty
  • They should work for unit tests in a "fluent" way as well as in the frontend
@KuechA
Copy link
Contributor

KuechA commented Oct 18, 2024

  • They should ideally simplify the scoping-system in the frontends and also in the tests.

For the transition phase:

  1. Replace Fluent since this DSL requires the ArgumentHolder and StatementHolder doesn't care about scopes and generally introduces errors in the tests sometimes

@konradweiss konradweiss added the code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxisto oxisto

@KuechA KuechA

Labels
code-quality Issues that do not require semantic changes to the code but rather cleanup, refactoring, commenting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oxisto @konradweiss @KuechA