From 55dea44c7bbc3c2bb53c71fefd8caa84b86379fb Mon Sep 17 00:00:00 2001
From: tienifr <christianwen18@gmail.com>
Date: Fri, 10 Nov 2023 11:50:46 +0700
Subject: [PATCH 1/3] add mention user rule

---
 lib/ExpensiMark.d.ts | 14 ++++++++++++--
 lib/ExpensiMark.js   | 33 ++++++++++++++++++++++++++++++---
 2 files changed, 42 insertions(+), 5 deletions(-)

diff --git a/lib/ExpensiMark.d.ts b/lib/ExpensiMark.d.ts
index 529e7b52..687d0f23 100644
--- a/lib/ExpensiMark.d.ts
+++ b/lib/ExpensiMark.d.ts
@@ -8,6 +8,15 @@ declare type Rule = {
     pre?: (input: string) => string;
     post?: (input: string) => string;
 };
+
+declare type PersonalDetail = {
+    accountID: string;
+    login?: string;
+    displayName?: string
+}
+
+declare type PersonalDetails = Record<string, PersonalDetail> | {}
+
 export default class ExpensiMark {
     rules: Rule[];
     htmlToMarkdownRules: Rule[];
@@ -57,13 +66,14 @@ export default class ExpensiMark {
      *
      * @param htmlString
      */
-    htmlToMarkdown(htmlString: string): string;
+    htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string;
     /**
      * Convert HTML to text
      *
      * @param htmlString
+     * @param personalDetails
      */
-    htmlToText(htmlString: string): string;
+    htmlToText(htmlString: string, personalDetails: PersonalDetails): string;
     /**
      * Modify text for Quotes replacing chevrons with html elements
      *
diff --git a/lib/ExpensiMark.js b/lib/ExpensiMark.js
index a1b01095..6c15e06f 100644
--- a/lib/ExpensiMark.js
+++ b/lib/ExpensiMark.js
@@ -350,6 +350,15 @@ export default class ExpensiMark {
                     return `[${g4}](${email || g3})`;
                 },
             },
+            {
+                name: 'mentionUser',
+                regex: /(<mention-user accountid="(.*?)">)(<\/mention-user>)/gi,
+                replacement: (openTag, accountID, closeTag, personalDetails) => {
+                    const user = _.get(personalDetails, accountID);
+                    const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
+                    return `${openTag}@${displayNameOrLogin}${closeTag}`;
+                }
+            },
         ];
 
         /**
@@ -388,6 +397,15 @@ export default class ExpensiMark {
                 regex: /<style>.*?<\/style>/gi,
                 replacement: '',
             },
+            {
+                name: 'mentionUser',
+                regex: /(<mention-user accountID=(.*?)>)(<\/mention-user>)/gi,
+                replacement: (openTag, accountID, closeTag, personalDetails) => {
+                    const user = _.get(personalDetails, accountID);
+                    const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
+                    return `${openTag}@${displayNameOrLogin}${closeTag}`;
+                }
+            },
             {
                 name: 'stripTag',
                 regex: /(<([^>]+)>)/gi,
@@ -628,10 +646,10 @@ export default class ExpensiMark {
      * Replaces HTML with markdown
      *
      * @param {String} htmlString
-     *
+     * @param {Object} personalDetails
      * @returns {String}
      */
-    htmlToMarkdown(htmlString) {
+    htmlToMarkdown(htmlString, personalDetails = {}) {
         let generatedMarkdown = htmlString;
         const body = /<(body)(?:"[^"]*"|'[^']*'|[^'"><])*>(?:\n|\r\n)?([\s\S]*?)(?:\n|\r\n)?<\/\1>(?![^<]*(<\/pre>|<\/code>))/im;
         const parseBodyTag = generatedMarkdown.match(body);
@@ -646,6 +664,10 @@ export default class ExpensiMark {
             if (rule.pre) {
                 generatedMarkdown = rule.pre(generatedMarkdown);
             }
+            if (rule.name === 'mentionUser') {
+                generatedMarkdown = generatedMarkdown.replace(rule.regex, (match, g1, g2, g3) => rule.replacement(g1, g2, g3, personalDetails));
+                return;
+            }
             generatedMarkdown = generatedMarkdown.replace(rule.regex, rule.replacement);
         });
         return Str.htmlDecode(this.replaceBlockElementWithNewLine(generatedMarkdown));
@@ -655,12 +677,17 @@ export default class ExpensiMark {
      * Convert HTML to text
      *
      * @param {String} htmlString
+     * @param {Object} personalDetails
      * @returns {String}
      */
-    htmlToText(htmlString) {
+    htmlToText(htmlString, personalDetails = {}) {
         let replacedText = htmlString;
 
         this.htmlToTextRules.forEach((rule) => {
+            if (rule.name === 'mentionUser') {
+                replacedText = replacedText.replace(rule.regex, (match, g1, g2, g3) => rule.replacement(g1, g2, g3, personalDetails));
+                return;
+            }
             replacedText = replacedText.replace(rule.regex, rule.replacement);
         });
 

From 3605180cd8a439f13508c11b8da65237bbe77ca2 Mon Sep 17 00:00:00 2001
From: tienifr <christianwen18@gmail.com>
Date: Fri, 10 Nov 2023 15:35:30 +0700
Subject: [PATCH 2/3] add more rules

---
 lib/ExpensiMark.js | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/lib/ExpensiMark.js b/lib/ExpensiMark.js
index 6c15e06f..5b1a318a 100644
--- a/lib/ExpensiMark.js
+++ b/lib/ExpensiMark.js
@@ -7,6 +7,12 @@ const MARKDOWN_LINK_REGEX = new RegExp(`\\[([^\\][]*(?:\\[[^\\][]*][^\\][]*)*)]\
 
 const SLACK_SPAN_NEW_LINE_TAG = '<span class="c-mrkdwn__br" data-stringify-type="paragraph-break" style="box-sizing: inherit; display: block; height: unset;"></span>';
 
+const userMentionReplacement = (openTag, accountID, closeTag, personalDetails) => {
+    const user = _.get(personalDetails, accountID);
+    const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
+    return `${openTag}@${displayNameOrLogin}${closeTag}`;
+};
+
 export default class ExpensiMark {
     constructor() {
         /**
@@ -353,11 +359,12 @@ export default class ExpensiMark {
             {
                 name: 'mentionUser',
                 regex: /(<mention-user accountid="(.*?)">)(<\/mention-user>)/gi,
-                replacement: (openTag, accountID, closeTag, personalDetails) => {
-                    const user = _.get(personalDetails, accountID);
-                    const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
-                    return `${openTag}@${displayNameOrLogin}${closeTag}`;
-                }
+                replacement: userMentionReplacement,
+            },
+            {
+                name: 'mentionUser',
+                regex: /(<mention-user accountID=(.*?)>)(<\/mention-user>)/gi,
+                replacement: userMentionReplacement,
             },
         ];
 
@@ -400,11 +407,7 @@ export default class ExpensiMark {
             {
                 name: 'mentionUser',
                 regex: /(<mention-user accountID=(.*?)>)(<\/mention-user>)/gi,
-                replacement: (openTag, accountID, closeTag, personalDetails) => {
-                    const user = _.get(personalDetails, accountID);
-                    const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
-                    return `${openTag}@${displayNameOrLogin}${closeTag}`;
-                }
+                replacement: userMentionReplacement
             },
             {
                 name: 'stripTag',

From f094a610db5e3845615c39a7884632faa86a7714 Mon Sep 17 00:00:00 2001
From: tienifr <christianwen18@gmail.com>
Date: Wed, 15 Nov 2023 10:33:55 +0700
Subject: [PATCH 3/3] change to use metadata

---
 lib/ExpensiMark.d.ts | 11 ++++++++---
 lib/ExpensiMark.js   | 12 +++++++-----
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/lib/ExpensiMark.d.ts b/lib/ExpensiMark.d.ts
index 687d0f23..4a795072 100644
--- a/lib/ExpensiMark.d.ts
+++ b/lib/ExpensiMark.d.ts
@@ -17,6 +17,10 @@ declare type PersonalDetail = {
 
 declare type PersonalDetails = Record<string, PersonalDetail> | {}
 
+declare type Metadata = {
+    personalDetails?: PersonalDetails
+}
+
 export default class ExpensiMark {
     rules: Rule[];
     htmlToMarkdownRules: Rule[];
@@ -65,15 +69,16 @@ export default class ExpensiMark {
      * Replaces HTML with markdown
      *
      * @param htmlString
+     * @param metadata
      */
-    htmlToMarkdown(htmlString: string, personalDetails: PersonalDetails): string;
+    htmlToMarkdown(htmlString: string, metadata?: Metadata): string;
     /**
      * Convert HTML to text
      *
      * @param htmlString
-     * @param personalDetails
+     * @param metadata
      */
-    htmlToText(htmlString: string, personalDetails: PersonalDetails): string;
+    htmlToText(htmlString: string, metadata?: Metadata): string;
     /**
      * Modify text for Quotes replacing chevrons with html elements
      *
diff --git a/lib/ExpensiMark.js b/lib/ExpensiMark.js
index 5b1a318a..d50d9e8a 100644
--- a/lib/ExpensiMark.js
+++ b/lib/ExpensiMark.js
@@ -7,7 +7,7 @@ const MARKDOWN_LINK_REGEX = new RegExp(`\\[([^\\][]*(?:\\[[^\\][]*][^\\][]*)*)]\
 
 const SLACK_SPAN_NEW_LINE_TAG = '<span class="c-mrkdwn__br" data-stringify-type="paragraph-break" style="box-sizing: inherit; display: block; height: unset;"></span>';
 
-const userMentionReplacement = (openTag, accountID, closeTag, personalDetails) => {
+const userMentionReplacement = (openTag, accountID, closeTag, personalDetails = {}) => {
     const user = _.get(personalDetails, accountID);
     const displayNameOrLogin = _.get(user, 'login', '') || _.get(user, 'displayName', '');
     return `${openTag}@${displayNameOrLogin}${closeTag}`;
@@ -649,10 +649,11 @@ export default class ExpensiMark {
      * Replaces HTML with markdown
      *
      * @param {String} htmlString
-     * @param {Object} personalDetails
+     * @param {Object} metadata
      * @returns {String}
      */
-    htmlToMarkdown(htmlString, personalDetails = {}) {
+    htmlToMarkdown(htmlString, metadata = {}) {
+        const {personalDetails} = metadata;
         let generatedMarkdown = htmlString;
         const body = /<(body)(?:"[^"]*"|'[^']*'|[^'"><])*>(?:\n|\r\n)?([\s\S]*?)(?:\n|\r\n)?<\/\1>(?![^<]*(<\/pre>|<\/code>))/im;
         const parseBodyTag = generatedMarkdown.match(body);
@@ -680,10 +681,11 @@ export default class ExpensiMark {
      * Convert HTML to text
      *
      * @param {String} htmlString
-     * @param {Object} personalDetails
+     * @param {Object} metadata
      * @returns {String}
      */
-    htmlToText(htmlString, personalDetails = {}) {
+    htmlToText(htmlString, metadata = {}) {
+        const {personalDetails} = metadata;
         let replacedText = htmlString;
 
         this.htmlToTextRules.forEach((rule) => {