mWeb - Subscription - Control plan modal does not have bottom padding

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Create a workspace.
4. Go back to Settings.
5. Go to Subscription tab.

Expected Result:

Control plan modal will have bottom padding.

Actual Result:

Control plan modal does not have bottom padding on mweb.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6711591_1736572550418.ScreenRecording_01-11-2025_13-10-27_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[shubham1206agra]

Offending PR #54771

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Control plan modal does not have bottom padding

What is the root cause of that problem?

The issue arises because both cards are styled to have the same overall height. However, the Collect card has 7 benefits, which fully utilize the available height, leaving no remaining space at the bottom. On the other hand, the Control card has 6 benefits, resulting in unused vertical space that display as additional bottom padding, creating an inconsistent appearance between the two cards.

What changes do you think we should make in order to solve the problem?

here

App/src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCard.tsx

Line 35 in 4491e85

<View style={[styles.borderedContentCard, styles.flex1, styles.mt5, styles.p5, index === 0 && styles.mr3, plan.isSelected && styles.borderColorFocus]}>

We can modify the condition to include multiple styles by wrapping them in an array, like this:

    index === 0 && [styles.mr3, styles.pb6]

This ensures that both styles.mr3 and styles.pb6 are applied when index === 0.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

N/A