[HOLD for payment 2024-12-30] [Awaiting payment][$250] Mark down - The sent message containing two > does not display double quote mark down

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat
3. Type >> hello
4. Note that the live mark down displays the nested quote
5. Send the message

Expected Result:

The sent message containing two > will display double quote mark down

Actual Result:

The sent message containing two > does not display double quote mark down

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537871_1720617437950.double_quote.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856771063028418492
• Upwork Job ID: 1856771063028418492
• Last Price Increase: 2024-11-13

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[devguest07]

Caused by #44262

[pecanoro]

Confirmed and posted in the PR, we probably need to assign the people to fix it!

[pecanoro]

Oh, but maybe we don't need to hold on this as it only happens when you do >> which it's an edge case

[mountiny]

Yeah lets not hold on this, we have to get to higher version of the markdown library and this does not seem that big issue

Please feel free to reassign to me, happy to handle this with swm or community upstream

[mountiny]

cc @Skalakid @BrtqKr @BartoszGrajdek @tomekzaw

[BartoszGrajdek]

I think @BrtqKr will be the best person to help you here since he was the one working on block quotes 🙌🏻

[BrtqKr]

Blockquote requires a space following it. If there are two blockquotes, they still need to be separated with a space. This was meant to allow empty lines to be treated as a part of the blockquote and prevent some of the issues with treating '>' as a blockquote unintentionally. I think this should go the other way - the input shouldn't show that this would result in a blockquote.

[pecanoro]

@BrtqKr Let me know if I am following correctly, the problem here is that the composer should not show the preview of the markdown, right?

[melvin-bot]

@JmillsExpensify, @pecanoro, @Pujan92, @Skalakid, @BrtqKr Eep! 4 days overdue now. Issues have feelings too...

[tomekzaw]

#53627 has been merged so this issue should be resolved now.

[pecanoro]

@JmillsExpensify I think the only thing left here is pay @Pujan92 for the review

[melvin-bot]

@JmillsExpensify, @pecanoro, @Pujan92, @Skalakid, @BrtqKr Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump react-native-live-markdown (use worklets) #53627

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment through NewDot Manual Requests
• @Skalakid does not require payment (Contractor)
• @BrtqKr does not require payment (Contractor)

[melvin-bot]

@Pujan92 @JmillsExpensify @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@JmillsExpensify, @pecanoro, @Pujan92, @Skalakid, @BrtqKr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Pujan92 owed $250 via NewDot
• Contributor: @Skalakid is from an agency-contributor and not due payment
• Contributor: @BrtqKr is from an agency-contributor and not due payment

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1856771063028418492/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Payment summary above is correct. @Pujan92 do you mind completing the BZ checklist?

[Pujan92]

Regression Test Proposal

1. Go to any chat
2. Type message >> Hello OR any valid blockquote format
3. Note that the live markdown displays the nested quote
4. Send the message
5. Verify the sent message should also display the markdown message correctly(nested blockquote)

[melvin-bot]

@JmillsExpensify, @pecanoro, @Pujan92, @Skalakid, @BrtqKr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify, @pecanoro, @Pujan92, @Skalakid, @BrtqKr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[garrettmknight]

$250 approved for @Pujan92