[Pay July 23?][$500] mWeb - Chat - Quotes without text are not shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4554720
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap on a report
3. Paste the text

> cat

>
>
> has

4. Send the message

Expected Result:

Where

> cat

>
>
> has

should render as

cat

has

For avoidance of doubt, it's this (screenshot)

Actual Result:

Empty quotes at 3rd & 4th line are not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479319_1715603469787.g_b.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0198eff8474488c59c
• Upwork Job ID: 1793084369808314368
• Last Price Increase: 2024-08-02

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[mallenexpensify]

@dannymcclain 👀 plz. the bug is that this

Renders as

So the two lines that only have > aren't recognized. My guess is this is an edge case we can fix on the cheap (I'd start the job at $125). Wanted to check with you before moving forward.

fwiw... I also tested another version that I thought would be more common and it was rendered as expected

rendered

[dannymcclain]

@mallenexpensify I'm actually a little torn on this. The way ours is working looks pretty identical to the way Github's markdown works... Here's the same situation in GH:

I think we should make the > in this situation display the quote block styling:

But I'm unsure if we should make empty >s display anything. @Expensify/design what do you think? What would you expect? I'm leaning towards this being fine as is, and just fixing the display of a > sandwiched between two other lines.

[shawnborton]

Yeah, I think that makes sense to me. So basically as soon as you start typing a > on a new line, we convert it to a block quote and add the border on the left?

[dannymcclain]

Yeah that's what I'm thinking.

[shawnborton]

Right on, I can get down with that.

[dubielzyk-expensify]

That sounds good to me too

[mallenexpensify]

@dannymcclain I wanna update the OP, how would you expect the below to show?

> cat

>
>
> has

[dannymcclain]

Github just gets rid of the two > lines above "has", so I'm tempted to follow that pattern.

It basically looks like they ditch any quoted lines unless the lines A) have text or B) are directly sandwiched between two quoted lines with text.

@Expensify/design do you have any other thoughts on how this should work? I don't know that I feel super strongly, just trying to arrive somewhere that makes sense and feels "normal".

[shawnborton]

I don't have any strong feelings either. I can see why GH does it the way they do, so I'd be cool with doing something like that.

[dubielzyk-expensify]

Github just gets rid of the two > lines above "has", so I'm tempted to follow that pattern.

Maybe GH has trained me, but that seems to make sense to me too.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0198eff8474488c59c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[mallenexpensify]

Thanks.... everyone on the design team :)

Updated OP and made external. Comment if it's not what y'all were thinking.

[gijoe0295]

@mallenexpensify I see that it's working as expected now, isn't it? Did I miss anything?

Screen.Recording.2024-05-22.at.09.23.31.mov

[situchan]

@gijoe0295 this is actual behavior:

Expected behavior:

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

This issue has not been updated in over 15 days. @dannymcclain, @mallenexpensify, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mallenexpensify]

Looks like the PR hit production 3 days ago, updated title and labels, let me know if they don't look correct @situchan

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mallenexpensify]

@situchan can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0182a80fe9e36869f3

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mallenexpensify]

@situchan can you please accept the job and reply here once you have?
upwork.com/jobs/~0182a80fe9e36869f3

[melvin-bot]

@dannymcclain, @mallenexpensify, @situchan Eep! 4 days overdue now. Issues have feelings too...

[situchan]

Not overdue

[situchan]

@mallenexpensify accepted thanks

[mallenexpensify]

Contributor+: @situchan paid $500 via Upwork.

@situchan plz complete the BZ checklist above.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@] The PR that introduced the bug has been identified. Link to the PR:
• [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@] Determine if we should create a regression test for this bug.
• [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
• [ ]

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[situchan]

There's no offending PR. This is an edge case we didn't consider.
Looks like we already have regression test for this - https://expensify.testrail.io/index.php?/tests/view/4554720

[mallenexpensify]

Thanks @situchan