You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lagacy branch appears when following case happens:
Say you have a feature branch foo and it's based on latest master. It changed utils. (So utils:latest__foo will be built)
New PRs have been merged into master. Say xud changed.
The foo branch is NOT based on latest master. So we diff it with latest master and it will show utils and xud changed. (So utils:latest__foo and xud:latest__foo will be built)
Now we rebase foo on latest master. (Only utils:latest__foo will be built now)
Till step 4 we got a legcy image xud:latest__foo left on DockerHub. If we do not delete this image, then the legacy xud will be used first when we run foo branch. It could lead to potential errors.
P.S.
The xud script will use branch image first. If it is missing then master image will be used instead.
Currently we need to manually remove legacy branch images on DockerHub to avoid such case happening.
I think we should remove legacy branch images on every build on bot side.
The text was updated successfully, but these errors were encountered:
The lagacy branch appears when following case happens:
utils:latest__foo
will be built)utils:latest__foo
andxud:latest__foo
will be built)utils:latest__foo
will be built now)Till step 4 we got a legcy image
xud:latest__foo
left on DockerHub. If we do not delete this image, then the legacy xud will be used first when we run foo branch. It could lead to potential errors.P.S.
I think we should remove legacy branch images on every build on bot side.
The text was updated successfully, but these errors were encountered: