Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy branch images on feature branch #11

Open
reliveyy opened this issue Aug 26, 2020 · 0 comments
Open

Remove legacy branch images on feature branch #11

reliveyy opened this issue Aug 26, 2020 · 0 comments
Assignees

Comments

@reliveyy
Copy link
Collaborator

The lagacy branch appears when following case happens:

  1. Say you have a feature branch foo and it's based on latest master. It changed utils. (So utils:latest__foo will be built)
  2. New PRs have been merged into master. Say xud changed.
  3. The foo branch is NOT based on latest master. So we diff it with latest master and it will show utils and xud changed. (So utils:latest__foo and xud:latest__foo will be built)
  4. Now we rebase foo on latest master. (Only utils:latest__foo will be built now)

Till step 4 we got a legcy image xud:latest__foo left on DockerHub. If we do not delete this image, then the legacy xud will be used first when we run foo branch. It could lead to potential errors.

P.S.

  1. The xud script will use branch image first. If it is missing then master image will be used instead.
  2. Currently we need to manually remove legacy branch images on DockerHub to avoid such case happening.

I think we should remove legacy branch images on every build on bot side.

@reliveyy reliveyy self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant