Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status flow improvements #23

Open
raladev opened this issue Dec 17, 2020 · 3 comments
Open

Status flow improvements #23

raladev opened this issue Dec 17, 2020 · 3 comments
Assignees
Labels
bug Something isn't working P2 mid priority

Comments

@raladev
Copy link
Contributor

raladev commented Dec 17, 2020

Would be good to avoid not display confused statuses during installation/syncing/restarting processes.

  • when xud container tries to get up on windows user can get no client status for xud -> would be good to change it to initializing...
  • Syncing (0/0) status for lnd after container creation would be good to change to Connecting to peers orGetting block numbers
  • During lnd wallet creation/unlocking process, lnd may get status that contain grpc err for 1-3 sec, would be good to prevet it too.

In general status flow should look like this without any error blinking:

xud:

Waiting for sync->Starting...->xud is locked->(if need some time to get ready stasus without any grpc error, we can add Unlocking... state)-> Ready

lnd:
Connecting to peers->Syncing(0/1234)->Waiting for wallet creation(if there is no wallet)/Waiting for unlock(if wallet was created before) -> Ready`

Connext:
Waiting for sync->Starting->Waiting for unlock->Ready

@raladev raladev added bug Something isn't working P2 mid priority labels Dec 17, 2020
@kilrau kilrau assigned peartobear and unassigned reliveyy and krrprr Dec 17, 2020
@kilrau
Copy link
Contributor

kilrau commented Dec 17, 2020

I actually discussed exactly this with @peartobear this morning. My proposal is to have a completely different Initializing... experience and definitely do not want to iterate through red error states and messages. Not on create and not on start neither. Check the recording of yesterday's call to see what I mean.

Compare the different states of Umbrel

State 0: immediately after getting back to the dashboard after logging out
image

State 1: showing more details on the state after 30s-1min
image

Hence I believe, this is an xud-ui issue, not xud-docker-api.

Ready for your takeover ;) @peartobear

@peartobear
Copy link

peartobear commented Dec 17, 2020

The umbrel one is using a skeleton loading lib like https://github.com/dvtng/react-loading-skeleton which can be used if we can get logs from users another way. And we can get designers to build empty state for every screen using these skeletons, until data is available to populate the UI components. @kilrau @krrprr

@kilrau
Copy link
Contributor

kilrau commented Dec 17, 2020

Please have a close look at the current messages the api exposes and see if you would want to change these. That's to be done in here, everything else -> new xud ui issue. @peartobear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 mid priority
Projects
None yet
Development

No branches or pull requests

5 participants