Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific tests for LocalSigner with Legacy transactions #165

Open
alisinabh opened this issue Dec 17, 2024 · 0 comments
Open

Add specific tests for LocalSigner with Legacy transactions #165

alisinabh opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alisinabh
Copy link
Member

As per EIP-155, Legacy transactions will have different signing behaviour depending on chain_id value. We need specific tests to actually test signing of Legacy transactions with and without chain_id present.

For fixtures anvil can be used to sign the same payload and compare.
@alisinabh alisinabh added enhancement New feature or request good first issue Good for newcomers labels Dec 17, 2024
@alisinabh alisinabh assigned alisinabh and unassigned alisinabh Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alisinabh