Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Network Type #16

Open
PersonalityPi opened this issue Jul 25, 2015 · 4 comments
Open

Switching Network Type #16

PersonalityPi opened this issue Jul 25, 2015 · 4 comments

Comments

@PersonalityPi
Copy link

Switching to Online. Sometimes crashes the game. (Release build)

@PersonalityPi
Copy link
Author

Also seems to happen even if you manage to host game. Not sure if this just a general HO problem or not. 80% sure it is but just mentioning it anyway.

@emoose
Copy link
Contributor

emoose commented Jul 25, 2015

Does this ever happen with ED at all?

I think it's related to the VoIP code in ChatPlugin, I noticed VoIP caused some crashes before but they've seemed to go away for me now, although sometimes when I switch to online and the VoIP text is being printed to the console http://i.imgur.com/X1HF8YF.png happens (where the text on the lobby menu just disappears)

If I disable the ChatPlugin it seems to work fine though. Maybe we'll have to recode the VoIP stuff, I noticed a lot of it seemed based on the sample TS3 code, it'd probably be better to recode it as part of the ModuleVoIP class instead.
Or it might be because I'm missing the soundbackends folder... I'll have to try copying it from my ED install now and see if it makes any difference.

Can you try renaming the ChatPlugin.dll to .dll_ and see if the crash still happens? Also do you have a soundbackends folder in your DR HO install?

@PersonalityPi
Copy link
Author

Doesn't seem to happen in ED. The second one I mentioned still happens but I think thats just related to HO itself rather then eldorito (It being hacky and all).

I think the disappearing of menu text happened way before VOIP though. I think thats always been a general issue. I'm pretty sure that only started happening when DXHook was added in.

Yeah I have the soundbackends folder in. I'll try renaming the plugin.

@PersonalityPi
Copy link
Author

Yeah Didn't crash at all. With the DLL renamed. The crash is completely random though so I could have just been lucky.

However, I noticed if you tried to change the network type while the TS stuff was still loading up it would crash the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants