From 29f1c1c9990c84f0f22e31c3fbd032176ad36b90 Mon Sep 17 00:00:00 2001
From: Adam Ruzicka <a.ruzicka@outlook.com>
Date: Tue, 6 Sep 2022 10:21:17 +0200
Subject: [PATCH] Switch to untracked api where appropriate

---
 examples/chunked_output_benchmark.rb         | 2 +-
 examples/orchestrate.rb                      | 3 ++-
 examples/orchestrate_evented.rb              | 2 +-
 lib/dynflow/action/polling.rb                | 2 +-
 lib/dynflow/action/timeouts.rb               | 2 +-
 lib/dynflow/action/with_bulk_sub_plans.rb    | 2 +-
 lib/dynflow/action/with_polling_sub_plans.rb | 4 ++++
 lib/dynflow/action/with_sub_plans.rb         | 7 ++++++-
 8 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/examples/chunked_output_benchmark.rb b/examples/chunked_output_benchmark.rb
index 3aa3a3659..237b1c91b 100644
--- a/examples/chunked_output_benchmark.rb
+++ b/examples/chunked_output_benchmark.rb
@@ -12,7 +12,7 @@ def main_loop
     if output[:current] < input[:limit]
       consumed = yield
       output[:current] += consumed
-      plan_event(nil)
+      plan_event(nil, untracked: true)
       suspend
     end
   end
diff --git a/examples/orchestrate.rb b/examples/orchestrate.rb
index fdb3a42c6..bdf1cd120 100755
--- a/examples/orchestrate.rb
+++ b/examples/orchestrate.rb
@@ -1,6 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
+require_relative 'example_helper'
+
 example_description = <<DESC
   Orchestrate Example
   ===================
@@ -21,7 +23,6 @@
 
 DESC
 
-require_relative 'example_helper'
 
 module Orchestrate
 
diff --git a/examples/orchestrate_evented.rb b/examples/orchestrate_evented.rb
index 8df844dde..8b38f68e6 100755
--- a/examples/orchestrate_evented.rb
+++ b/examples/orchestrate_evented.rb
@@ -75,7 +75,7 @@ def run(event = nil)
                # do nothing
              end),
             (on nil do
-               suspend { |suspended_action| world.clock.ping suspended_action, rand(1), Finished }
+               suspend { |suspended_action| world.clock.ping suspended_action, rand(1), Finished, untracked: true }
              end))
     end
 
diff --git a/lib/dynflow/action/polling.rb b/lib/dynflow/action/polling.rb
index 2296644ff..a585f88f0 100644
--- a/lib/dynflow/action/polling.rb
+++ b/lib/dynflow/action/polling.rb
@@ -91,7 +91,7 @@ def resume_external_action
     end
 
     def suspend_and_ping
-      plan_event(Poll, poll_interval)
+      plan_event(Poll, poll_interval, untracked: true)
       suspend
     end
 
diff --git a/lib/dynflow/action/timeouts.rb b/lib/dynflow/action/timeouts.rb
index 92033227b..98e9950d1 100644
--- a/lib/dynflow/action/timeouts.rb
+++ b/lib/dynflow/action/timeouts.rb
@@ -8,7 +8,7 @@ def process_timeout
     end
 
     def schedule_timeout(seconds, optional: false)
-      plan_event(Timeout, seconds, optional: optional)
+      plan_event(Timeout, seconds, optional: optional, untracked: true)
     end
  end
 end
diff --git a/lib/dynflow/action/with_bulk_sub_plans.rb b/lib/dynflow/action/with_bulk_sub_plans.rb
index 6cf23f75d..b90484d5e 100644
--- a/lib/dynflow/action/with_bulk_sub_plans.rb
+++ b/lib/dynflow/action/with_bulk_sub_plans.rb
@@ -70,7 +70,7 @@ def run_progress
     def spawn_plans
       super
     ensure
-      plan_event(PlanNextBatch)
+      plan_event(PlanNextBatch, untracked: true)
     end
 
     def cancel!(force = false)
diff --git a/lib/dynflow/action/with_polling_sub_plans.rb b/lib/dynflow/action/with_polling_sub_plans.rb
index 7b4d72ecc..7157e1e0d 100644
--- a/lib/dynflow/action/with_polling_sub_plans.rb
+++ b/lib/dynflow/action/with_polling_sub_plans.rb
@@ -70,5 +70,9 @@ def recalculate_counts
                     :failed_count  => failed - output.fetch(:resumed_count, 0),
                     :success_count => success)
     end
+
+    def can_fire_and_forget_sub_plans?
+      true
+    end
   end
 end
diff --git a/lib/dynflow/action/with_sub_plans.rb b/lib/dynflow/action/with_sub_plans.rb
index 3be37e69a..5e3d31451 100644
--- a/lib/dynflow/action/with_sub_plans.rb
+++ b/lib/dynflow/action/with_sub_plans.rb
@@ -81,7 +81,8 @@ def trigger(action_class, *args)
       if uses_concurrency_control
         trigger_with_concurrency_control(action_class, *args)
       else
-        world.trigger { world.plan_with_options(action_class: action_class, args: args, caller_action: self) }
+        method = can_fire_and_forget_sub_plans? ? :trigger_untracked : :trigger
+        world.public_send(:trigger) { world.plan_with_options(action_class: action_class, args: args, caller_action: self) }
       end
     end
 
@@ -234,5 +235,9 @@ def check_for_errors!
     def uses_concurrency_control
       @uses_concurrency_control = input.key? :concurrency_control
     end
+
+    def can_fire_and_forget_sub_plans?
+      false
+    end
   end
 end