Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Automate testing of the database schema under different dialects #26

Open
goncalossilva opened this issue Jan 14, 2022 · 0 comments
Open
Labels
enhancement New feature or request server Specific to the server

Comments

@goncalossilva
Copy link
Member

There's a slight discrepancy on how SQLDelight's dialect is set and what database Hikari uses. The former is set at compile time, and the later is set at runtime. This can lead to weird problems even if there is effort to keep them in sync. All it takes is for us to compile with one combo (e.g., both on SQLite) and then run with another (e.g., both on PostgreSQL).

I'd like to solve this by keeping the SQL dialect to a minimum, ensuring there are no weird incompatibilities. But to ensure it stays this way in the future, we should be testing our schema and migrations with all dialects we accept.

@goncalossilva goncalossilva added enhancement New feature or request server Specific to the server labels Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request server Specific to the server
Projects
None yet
Development

No branches or pull requests

1 participant