Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build doesn't fail when adb missing from path #3436

Open
diablozzq opened this issue Dec 22, 2024 · 1 comment · May be fixed by #3493
Open

Android build doesn't fail when adb missing from path #3436

diablozzq opened this issue Dec 22, 2024 · 1 comment · May be fixed by #3493

Comments

@diablozzq
Copy link

Problem

The dx serve --platform android doesn't check for adb in path before trying to launch. If it's missing, it will Build complete successfully and not launch.

Steps To Reproduce

Remove $HOME/Library/Android/sdk/platform-tools from path i.e. adb. Then run dx serve --platform android with an Android emulator started. The app will build but not launch and not inform the user.

Expected behavior

An error should occur if adb is not found.

Environment:

  • Dioxus version: .6.0.1
  • Rust version: latest
  • OS info: Mac OSX
  • App platform: android
@Plebshot
Copy link

Plebshot commented Jan 3, 2025

As a new user, this had me really confused for a while and nearly steered me away from giving Dioxus another try because it just appeared broken. The docs do not mention needing adb either it seems. Thanks for clearing this up.

@Plebshot Plebshot linked a pull request Jan 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants