Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flac transcode target is ignored when skip_existing_formats_check is true and source is Flac24 #25

Open
RogueOneEcho opened this issue May 18, 2024 · 0 comments
Open

Flac transcode target is ignored when skip_existing_formats_check is true and source is Flac24 #25

RogueOneEcho opened this issue May 18, 2024 · 0 comments

Comments

@RogueOneEcho
Copy link
Contributor

I'm working my way through the source and was curious if this behaviour is intentional or not?

If you are attempting to:

  • transcode from Flac24
  • allowed_transcode_formats contains Flac
  • skip_existing_formats_check is false

then I would have expected that Flac would be included in transcode_formats but this is explicitly ignored:

red_oxide/src/command/transcode.rs

Line 198 in 3d20de1

&& (release_type != Flac || torrent.format != "FLAC")

Is this the expected behaviour?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RogueOneEcho