Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover why data processed are not the same across different envs #536

Closed
gcroci2 opened this issue Dec 19, 2023 · 0 comments
Closed

Discover why data processed are not the same across different envs #536

gcroci2 opened this issue Dec 19, 2023 · 0 comments
Assignees

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Dec 19, 2023

This turned out to be a False alarm.

Since we are editing the cutoff distance of the data generation tutorials in #528, when running the tutorials' training with the new settings we get nan losses. The reason is that the cutoff is now too low for the network to learn anything.

I got confused since this was not happening using my local environment from the main branch, and I think that the same happened to @DaniBodor.

Then I looked at the different HDF5 files generated and I noticed that the number of nodes and edges in each data point between the two "env" versions were different. So at first (not thinking at all about the cutoff distance edit, for some reason I missed it looking at the PR again), I thought that there was some bug going on that caused the processed data to be different in my local env case and the docker env case, either in how we released deeprank2 2.1.1 on PyPi or in some edits we did between 2.1.0 and 2.1.1 versions. I couldn't find anything though, so I double-checked again using both env on the same branch and it turned out to be just confusion between the different settings in the tutorials across the various branches.

@gcroci2 gcroci2 added bug Something isn't working priority Solve this first Query query module related issues labels Dec 19, 2023
@gcroci2 gcroci2 removed bug Something isn't working priority Solve this first Query query module related issues labels Dec 19, 2023
@gcroci2 gcroci2 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@gcroci2 gcroci2 moved this to Done in Development Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants