Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor buildgraph module #506

Closed
2 tasks
DaniBodor opened this issue Sep 23, 2023 · 3 comments · Fixed by #507
Closed
2 tasks

Refactor buildgraph module #506

DaniBodor opened this issue Sep 23, 2023 · 3 comments · Fixed by #507
Labels
stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

DaniBodor commented Sep 23, 2023 •
edited
Loading

Lots of duplicate code in this module.

TODO:

  • Unify build_atomic_graph and build_residue_graph into single function with resolution kw
  • Check for other instances

blocked by #490
This was referenced Sep 23, 2023
Merged
Merged
@gcroci2 gcroci2 added the priority Solve this first label Sep 27, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Oct 30, 2023
@DaniBodor DaniBodor removed the stale issue not touched from too much time label Oct 31, 2023
@DaniBodor DaniBodor mentioned this issue Nov 7, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Dec 1, 2023
@DaniBodor
Copy link
Collaborator Author

not sure why this didnt get closed with #507 , but will do it now

@gcroci2 gcroci2 added SS and removed SS priority Solve this first labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale issue not touched from too much time
Projects
SSP: Diversifying molecule coverage
Status: Done
Milestone
No milestone
2 participants
@DaniBodor @gcroci2