Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTYPE should track all listed options #202

Open
DavidRieman opened this issue Nov 17, 2024 · 0 comments
Open

TTYPE should track all listed options #202

DavidRieman opened this issue Nov 17, 2024 · 0 comments
Labels
enhancement This task is adding new behavior or performing other refactoring improvements. good first issue This task is likely to be suitable for newcomers to the WheelMUD repo as one of their first tasks.

Comments

@DavidRieman
Copy link
Owner

DavidRieman commented Nov 17, 2024

In short, this is probably a simple matter of having a List that we populate next to TerminalOptions.TerminalType which we add each unique string to. It should probably also have a reasonable but generous max to how many we populate (to avoid infinite memory growth attack), maybe 40 total items? 40 is also the max item string length (we should cap it to avoid growth as well), per:
(https://www.iana.org/assignments/terminal-type-names/terminal-type-names.xhtml)

Basically, it seems like a MUD should have an avenue to use reported TTYPE options to make decisions about what the client can receive and handle, even if it is no the "active" default option reported - which could be a matter of querying a TerminalOptions List to see if a given option is within.

Once this is done, we may want to create a new ticket to: Study what kinds of ttype entries are reported commonly by common clients, to see what other features we may want (e.g. perhaps systemizing determiniation color modes available in addition to giving the user a way to override the automatic detection)

@DavidRieman DavidRieman added enhancement This task is adding new behavior or performing other refactoring improvements. good first issue This task is likely to be suitable for newcomers to the WheelMUD repo as one of their first tasks. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This task is adding new behavior or performing other refactoring improvements. good first issue This task is likely to be suitable for newcomers to the WheelMUD repo as one of their first tasks.
Projects
None yet
Development

No branches or pull requests

1 participant