Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ANSI code input sanitization #188

Open
DavidRieman opened this issue Aug 20, 2024 · 0 comments
Open

Improve ANSI code input sanitization #188

DavidRieman opened this issue Aug 20, 2024 · 0 comments

Comments

@DavidRieman
Copy link
Owner

DavidRieman commented Aug 20, 2024

(Related to #187...) There are cases where we do want users to be able to mark up color and such (writing message board notes and the like) but in many other cases that may be detrimental for various reasons.

We may want a mechanism where color codes and the like can only be used on certain commands? Also, can only be used if the user has "permissions" to do so? On a case by case basis, an admin may also allow say commands and the like to be colorized. (Recommend any default implementation though to be careful not to let them impersonate line wrapped texts to look like "real" game output.)

For this ticket, we need to give some heavier architectural thought about when/how we sanitize user inputs. We need to ensure that user inputs like say \ACTUAL escape codes here also definitely get sanitized before the command processor. (At least I think all escape codes the server receives should never get passed through to command processing...) Write tickets for any follow-up work discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant