Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: dict word printing #301

Open
erkyrath opened this issue Aug 8, 2024 · 0 comments
Open

Cleanup: dict word printing #301

erkyrath opened this issue Aug 8, 2024 · 0 comments

Comments

@erkyrath
Copy link
Contributor

erkyrath commented Aug 8, 2024

There's some messy logic which could be improved.

print_dict_word() decodes Z-characters and tries to show them in escaped form (@{3c1} or @oe). We could reasonably soften this to allow native printing of characters in the -Cn set, or UTF8 printing in -Cu mode. This is already partially done, in fact; but we're going through a function called word_to_ascii() which makes life confusing.

(word_to_ascii() is misnamed: it can output Latin-1 characters.) (Also, it's Z-code only and the name should reflect that!)

While we're at it, why is dict word printing handled in two places? Why do the printing functions have the annoying dual d_show_buf logic? Rethink this entire area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant