Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rn_base models #50

Open
2 tasks
Baachi opened this issue Jun 26, 2019 · 2 comments
Open
2 tasks

Update rn_base models #50

Baachi opened this issue Jun 26, 2019 · 2 comments
Labels
BC Break This change cause a BC break enhancement help wanted

Comments

@Baachi
Copy link
Contributor

Baachi commented Jun 26, 2019 •
edited by rengaw83
Loading

Currently we use the old models from rn_base and should migrate to the new DomainInterface.

I'm not sure, if this is a BC break but it might be worth.

  • Replace direct $model->record usage:
    $model->record['title'] becomes $model->getTitle() or $model->getProperty('title')
  • Replace tx_rnbase_IModel with Tx_Rnbase_Domain_Model_DataInterface
@Baachi
Copy link
Contributor Author

Baachi commented Jun 26, 2019

@digedag @rengaw83 @hannesbochmann Any suggestions?

@Baachi Baachi added the BC Break This change cause a BC break label Jun 26, 2019
@rengaw83
Copy link
Member

it is a bc, but yes, we should change this, it will be worth it!

digedag added a commit that referenced this issue Nov 19, 2021
@digedag
#50 remove deprecated model interfaces for support of rn_base 1.14
a2d3169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break This change cause a BC break enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baachi @rengaw83