Skip to content
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.

Fix Plotting Dependencies on Calibration vs. Holdout Purchases #50

Open
ColtAllen opened this issue Jul 31, 2022 · 0 comments
Open

Fix Plotting Dependencies on Calibration vs. Holdout Purchases #50

ColtAllen opened this issue Jul 31, 2022 · 0 comments
Labels
enhancement New feature or request invalid This doesn't seem right
Milestone

Comments

@ColtAllen
Copy link
Owner

It's been a longstanding issue in the legacy Lifetimes library that the plot_calibration_purchases_vs_holdout_purchases function in plotting.py cannot be used without first running data through calibration_and_holdout_data in utils.py. This is a useful plotting function for model evaluation, but for those of us working with huge volumes of transaction data, utils.py just isn't going to cut it and the RFM aggregations must be done in a separate service like Spark or Snowflake, effectively blocking the use of this function.

Replacing the calibration_holdout_matrix argument with separate calibration_matrix and holdout_matrix arguments should be enough to resolve this matter.

@ColtAllen ColtAllen added enhancement New feature or request invalid This doesn't seem right labels Jul 31, 2022
@ColtAllen ColtAllen added this to the Beta Release milestone Jul 31, 2022
@ColtAllen ColtAllen added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant