New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strncpy #10

Open

lross2k opened this issue May 11, 2023 · 0 comments

Labels

bug

Member

lross2k commented May 11, 2023

Problem

As I have learned in the last days, strncpy isn't a memory safe function because of the following

Doesn't null terminate \0 so if we use this function, str[STR_MAX_LENGHT] = '\0' should be used.
Won't inform if truncation was done, this can end up causing DoS or privilege elevation.

Solution

memcpy (If we know the source strlen)
snprintf

lross2k added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment