-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on LocusZoom Plot Enhancements #120
Comments
As you can see in the figure, there are 3 different SNPs, and only one is labeled. It is not clear which is the top SNP in EUR and there is no corresponding LD box with colors, along with the SNP. Even for EAS, one gets an idea about the top SNP from LD box (rs74284577) only. |
Thank you for your great work on this tool. Let us consider a specific scenario where the goal is to highlight the top variant for Females, Males, and the combined Male-Female dataset (specified as the reference in the main script). While there may or may not be overlaps between these three variants, I wanted to share some ideas that might help improve the clarity and usability of the plot. LD Reference SNP Display Label Differentiation Automation for Identifying Top SNPs Perhaps, one can also have 3 panels in such a scenario. That would be the best solution. These are just my thoughts as a user. I’m not an expert, so please feel free to correct me or share your perspective. I hope this feedback is helpful and contributes to improving the tool’s functionality. |
Hi, To summarize, I guess I will implement the workflow as:
I will try to do some tests and implement this in next a few versions possibly. Thank you again for the BTW, actually you can add up to 9 panels using plot_stacked_mqq() by simply passing a list of objects:
|
I wish you all the best. You are doing outstanding work, and your data handling and visualizations are among the best I’ve seen. I eagerly look forward to your updates and hope to incorporate them into my next publication in a few months. |
Just one final comment: how would you distinguish between top variants in different panels with overlapping LD? For instance, in your latest graph, if the dark red overlaps with the dark green, it could cause some confusion. I think the best approach would be to restrict each panel to use the classical locus zoom coloring for the respective top variants. Alternatively, you could provide users with the option to choose different color schemes for each panel (e.g., red, blue, green) to make them more distinct, rather than mixing all the colors in each panel. |
Thank you very much for your kind words. Regarding your comment, SNPs are colored against the reference variants with which they are in highest LD. This is consistent with the original LocusZoom regional plot for multiple reference SNPs (as described in https://genome.sph.umich.edu/wiki/LocusZoom_Standalone#Optional_Input). I will implement this an option so that users can select the style that they want. |
I wanted to reach out regarding potential improvements to the zoom plot visualization.
It can often be challenging to explain the relationship between the upper and lower panels of a locus zoom plot, especially when the top hit in the lower panel differs from the one in the upper panel. This issue arises because the lower panel does not explicitly indicate which SNP it is showing LD with. Additionally, when the lower panel SNP is different from the upper panel SNP, it is often left unlabeled, leading to further confusion.
Things become even more complicated when an entirely different SNP is the focus, which is neither the top SNP in the upper panel nor in the lower panel (as demonstrated in the attached example).
Would it be possible to include an LD box or label within the lower panel that specifies which SNP the LD is being calculated against, along with corresponding color codes? This enhancement would make it much clearer and eliminate the assumption that LD in the lower panel is always relative to the SNP marked in the upper LD panel box.
Thank you for considering this suggestion, and I look forward to your thoughts!
Best regards,
The text was updated successfully, but these errors were encountered: