Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags should be coerced to lowercase strings #224

Open
delgadom opened this issue Mar 21, 2017 · 2 comments
Open

tags should be coerced to lowercase strings #224

delgadom opened this issue Mar 21, 2017 · 2 comments
Assignees
Milestone

Comments

@delgadom
Copy link
Member

name/case conflicts, type mismatch, and other issues are popping up. getting this right is critical to making DataFS usable.

@delgadom delgadom added this to the 0.7.1 milestone Mar 21, 2017
@jgerardsimcock jgerardsimcock self-assigned this Apr 6, 2017
@jgerardsimcock
Copy link
Contributor

Two parts of this issue as far as I can see.

  1. A script to go through all archives and coerce all tags to lower case strings.
  2. Changes to api.manager._set_tags that coerces all tags to lower case strings.

Going to open another issue that address #2. 1 is easy enough but would prefer feedback before I go ahead and implement this.

@delgadom
Copy link
Member Author

This sounds great. I think the script is pretty straightforward, with a couple tweaks for our specific use case.

For one, dynamo seems to have coerced all floats to Decimal-precision values, so I'd want to check to make sure, e.g., that Decimal('2.01') gets converted to '2.01' not "Decimal('2.01')"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants