Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query method in Reader class #10

Open
lukavdplas opened this issue May 11, 2023 · 1 comment
Open

Query method in Reader class #10

lukavdplas opened this issue May 11, 2023 · 1 comment
Assignees

Comments

@lukavdplas
Copy link
Contributor

Each Reader object should have a query method that allows a (rudimentary) search through the catalogus.

For example, we might support the following queries:

  • minimum / maximum date
  • search for keywords in:
    • the author or publisher
    • any bibliographical field, or any biographical field
    • any metadata

Note that this may include and/or logic.

It probably makes sense if we makes sense to decide on a JSON representation of the query here, which will ultimately be generated by the EDPOP frontend.

@jgonggrijp
Copy link

Note that this may include and/or logic.

I suggest not in a way that the user can control (let alone nest), though. Either all query parameters are ORed, or they are all ANDed. I suspect the latter would be less surprising to the user, but I can be easily convinced otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants