-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PR command #4
Comments
Per conversation with @Leo6Leo: git make-pr -r <remote_name: defaults to upstream>
-u <remote_url: if provided, overrides -r>
-s <: whether or not to stash any uncommited changes>
-c <commit_message: commit uncomitted but staged changes with commit_message> |
If
If after following this resolution process there are any remaining unstashed/uncommitted changes the command will fail. @Leo6Leo do you think we should also add a |
I think it's generally advised to ensure that there are no uncommitted/unstashed changes before making a PR. This is to make sure that the changes being proposed are clear, complete, and can be easily reviewed and tested by others. But things happens sometimes, adding a -f flag (force flag) could potentially be useful, but it should be used with caution. We might need to highlight the potential risks involved in using this flag (like causing confusion for reviewers or even introducing bugs if the changes are not fully ready), and it should generally be discouraged unless there's a clear need for it. @Cali0707 |
This command would just open the make PR window in the browser, sort of like if you clicked on the PR link when you first push a change to a new branch.
In order for this to be complete, the following tasks must be finished:
The text was updated successfully, but these errors were encountered: