Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password astericks when the auth token is saved #254

Open
SteadyCadence opened this issue Aug 23, 2017 · 4 comments
Open

Add password astericks when the auth token is saved #254

SteadyCadence opened this issue Aug 23, 2017 · 4 comments

Comments

@SteadyCadence
Copy link
Contributor

The URL and username are saved when the auth token is saved. We should be consistent and have the password also filled in with astericks. That removes confusion from users.

I will also work on updating the wording so that it is more clear.

@dimasciput
Copy link
Collaborator

I don't think filled in password is a good idea for security purpose, we didn't store the password, we just store the username. We could add the asterick.

@dimasciput
Copy link
Collaborator

@SteadyCadence

@amplifi
Copy link

amplifi commented Aug 29, 2017

@dimasciput Agreed; we should not be storing or caching user passwords anywhere.

@SteadyCadence
Copy link
Contributor Author

I agree. Let's just put in 10 astericks or something.

In other news, I like the greyed out fields when the username and password are stored. Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants