Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised Description of "PowerOptimizeLevel" Parameter with Suggested Addition #661

Closed
UmangSharmaMobis opened this issue Sep 26, 2023 · 8 comments
Labels
Status:Review Please review/discuss contents

Comments

@UmangSharmaMobis
Copy link
Contributor

PowerOptimizeLevel:
datatype: uint8
type: actuator
min: 0
max: 10
description: |
Power optimization level for this branch/subsystem.
A higher number indicates more aggressive power optimization.
Level 0 indicates that all functionality is enabled, no power optimization enabled.
Level 10 indicates most aggressive power optimization mode, only essential functionality enabled.

Note: This definition does not include an automatic optimization level. Some specific specifications or features may be handled automatically by the OEM during runtime.

Suggested Addition:
Level 11 - Auto: This level enables automatic optimization, allowing the system to dynamically adjust the power optimization level based on specific runtime conditions or features handled by the OEM.

I've included your suggested addition for Level 11 - Auto, which enables automatic optimization, allowing the system to dynamically adjust the power optimization level based on specific runtime conditions or features handled by the OEM.
@erikbosch erikbosch added the Status:Review Please review/discuss contents label Sep 26, 2023
@erikbosch
Copy link
Collaborator

Meeting notes:

  • Umang introduced the issue
  • Please discuss, to be discussed/decided next meeting

@SebastianSchildt
Copy link
Collaborator

I am not sure, if we should add "magic numbers". That feels a lot like lower level CAN stuff, which we like to "transcend" with VSS.

Maybe another approach would be to have a bool AutoPowerOptimze. If it is true convetion might be that PowerOptimizeLevel just reflects the current status chosen by the Auto Optimizer (or maybe stays at 0, maybe an implemtation detail), and if somebody chooses a manual level by writing to PowerOptimizeLevel an implementation might set AutoPowerOptimze to false

But that is just one example, my main point is, I think VSS should not have "magic numbers" wherein "0. to 10" means "0 to 10", but "11" or "-5" in the same signal mean some special condition.

@UmangSharmaMobis
Copy link
Contributor Author

I agree with you as well, Sebastian. My initial thought was to introduce an additional level as '11' and designate it as an automatic level. However, your suggestion of using 'AutoPowerOptimize' with a boolean datatype is a better approach and will effectively address the issue.

@UmangSharmaMobis
Copy link
Contributor Author

is this fine ?

AutoPowerOptimize:
datatype: bool
type: actuator
description: Auto Power Optimization Flag
When set to 'true', the system enables automatic power optimization,
dynamically adjusting the power optimization level based on runtime conditions
or features managed by the OEM.
When set to 'false', manual control of the power optimization level is allowed.

@erikbosch
Copy link
Collaborator

Is the intention then to just have a single AutoPowerOptimize, or one in every place we today have PowerOptimizeLevel?

@UmangSharmaMobis
Copy link
Contributor Author

The intention is to introduce an additional level specifically for AUTO. This level can either be defined within the existing level range or utilize a new signal called AutoPowerOptimize

@erikbosch
Copy link
Collaborator

Meeting notes:

  • Umang to create pull request
  • Then please review

@UmangSharmaMobis
Copy link
Contributor Author

AutoPowerOptimize signal has been added in #670 issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Review Please review/discuss contents
Projects
None yet
Development

No branches or pull requests

3 participants