-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised Description of "PowerOptimizeLevel" Parameter with Suggested Addition #661
Comments
Meeting notes:
|
I am not sure, if we should add "magic numbers". That feels a lot like lower level CAN stuff, which we like to "transcend" with VSS. Maybe another approach would be to have a bool AutoPowerOptimze. If it is But that is just one example, my main point is, I think VSS should not have "magic numbers" wherein "0. to 10" means "0 to 10", but "11" or "-5" in the same signal mean some special condition. |
I agree with you as well, Sebastian. My initial thought was to introduce an additional level as '11' and designate it as an automatic level. However, your suggestion of using 'AutoPowerOptimize' with a boolean datatype is a better approach and will effectively address the issue. |
is this fine ? AutoPowerOptimize: |
Is the intention then to just have a single |
The intention is to introduce an additional level specifically for AUTO. This level can either be defined within the existing level range or utilize a new signal called AutoPowerOptimize |
Meeting notes:
|
AutoPowerOptimize signal has been added in #670 issue can be closed |
PowerOptimizeLevel:
datatype: uint8
type: actuator
min: 0
max: 10
description: |
Power optimization level for this branch/subsystem.
A higher number indicates more aggressive power optimization.
Level 0 indicates that all functionality is enabled, no power optimization enabled.
Level 10 indicates most aggressive power optimization mode, only essential functionality enabled.
The text was updated successfully, but these errors were encountered: