Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMILES parsing doesn't set atom types #109

Open
rajarshi opened this issue Sep 21, 2020 · 1 comment
Open

SMILES parsing doesn't set atom types #109

rajarshi opened this issue Sep 21, 2020 · 1 comment

Comments

@rajarshi
Copy link
Collaborator

Atom types can be perceived using the following code

acm <- J("org.openscience.cdk.tools.manipulator.AtomContainerManipulator")
acm$percieveAtomTypesAndConfigureAtoms(mol)

This does not happen by default when parsing a SMILES or reading an SDF. Either provide this as a function (e..g, set.atom.types) or else include in the molecule parsing/loading function as a optional parameter.

In both cases, should support the possibility of different atom typing schemes

@rajarshi
Copy link
Collaborator Author

There was a function, do.typing that implemented this. Renamed to set.atom.types and updated the code to use J notation. Currently only supports CDK atom types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant