Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid magic numbers (Ether address) #3

Open
ryu9827 opened this issue Jul 23, 2019 · 0 comments
Open

Avoid magic numbers (Ether address) #3

ryu9827 opened this issue Jul 23, 2019 · 0 comments
Labels
best practice minor

Comments

@ryu9827
Copy link

ryu9827 commented Jul 23, 2019

multisender/contracts/contracts/multisender/UpgradebleStormSender.sol

Line 103 in 17153e9

if (token == 0x000000000000000000000000000000000000bEEF){

multisender/contracts/contracts/multisender/UpgradebleStormSender.sol

Line 132 in 17153e9

Multisended(msg.value, 0x000000000000000000000000000000000000bEEF);

Suggest replace the address 0x000000000000000000000000000000000000bEEF with a constant variable. It improves readability and maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryu9827