Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BG:EE] Release familiar from pack doesn't work #10

Open
artifoxel opened this issue Jul 10, 2022 · 0 comments
Open

[BG:EE] Release familiar from pack doesn't work #10

artifoxel opened this issue Jul 10, 2022 · 0 comments

Comments

@artifoxel
Copy link

artifoxel commented Jul 10, 2022 •
edited
Loading

As reported by CajunAzn on G3 forums, in BGEE if you put the familiar in the pack and release it, the familiar doesn't show up—and dissappears from the bag (and you can't summon again)!

The reason this is happening is that baldur.bcs is not getting patched with the code from newfam.baf, which handles the global variables set when the "Release Familiar" ability is used. In the setup-wtpfamiliars.tp2, the installer looks for the block of code in oldfam.baf to replace with the code in newfam.baf.

However, the replacement search fails because of the line for BG2:EE's baldur.bcs:

MoveGlobalObject("fampsd",Player1) // Pseudo-dragon

is changed in BG:EE's baldur.bcs to:

MoveGlobalObject("fampsd",Player1) // Pseudo Dragon

Yes, it's weird that WeiDU will care what the comment string is for REPLACE_BCS_BLOCK 🤷, but I created a modified setup-wtpfamiliars.tp2 and oldfam.bat that fixes this (and the other two bugs I reported).

https://github.com/artyfox/WTPFamiliars/archive/refs/heads/master.zip

Hope you enjoy! 🐕
artifoxel added a commit to artifoxel/WTPFamiliars that referenced this issue Jul 11, 2022
@artifoxel
First patch for BG:EE compatibility
b035c43 
- Fix incorrect/missing strings for BG:EE (Black-Wyrm-Lair#8)
- More consistent summoning checks for BG(2):EE (Black-Wyrm-Lair#9)
- Allow patching of BG:EE `baldur.bcs` for "Release Familiar" item ability (Black-Wyrm-Lair#10)
artifoxel added a commit to artifoxel/WTPFamiliars that referenced this issue Jul 11, 2022
@artifoxel
First patch for BGEE compatibility
1ec0ebb 
- Fix incorrect/missing strings for BGEE (Black-Wyrm-Lair#8)
- More consistent summoning checks for BG(2)EE (Black-Wyrm-Lair#9)
- Allow patching of BGEE `baldur.bcs` for "Release Familiar" item ability (Black-Wyrm-Lair#10)

*Switched to IESDP labels for game versions (without semicolon)
artifoxel added a commit to artifoxel/WTPFamiliars that referenced this issue Jul 11, 2022
@artifoxel
First patch for BGEE compatibility
0b60f15 
- Fix incorrect/missing strings for BGEE (Black-Wyrm-Lair#8)
- More consistent summoning checks for BG(2)EE (Black-Wyrm-Lair#9)
- Allow patching of BGEE `baldur.bcs` for "Release Familiar" item ability (Black-Wyrm-Lair#10)

*Switched to IESDP labels for IE game variants (without semicolon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artifoxel