You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In org.bgee.model.topanat.TopAnatRManager, see lines 189-191 in develop branch: p-value and number of significant nodes are taken into account to count the results, not to actually filter them (see line 169).
In /bgee-core/src/main/resources/R_scripts/topAnat_functions.R, we need to modify the function makeTable to accept these thresholds as arguments, and use them. Then we need to modify the call to this makeTable function.
@jwollbrett: do you feel like making this change? I guess it affects the R package as well. If you do make the change in the Java app, you need to checkout from branch archive_common_bgee_v13_and_later, since this problem also affects Bgee 13.
(I don't think it is absolutely necessary for the release, as the bug is there since a long time I think)
The text was updated successfully, but these errors were encountered:
In GitLab by @fbastian on Feb 13, 2018, 13:39
In
org.bgee.model.topanat.TopAnatRManager
, see lines 189-191 indevelop
branch: p-value and number of significant nodes are taken into account to count the results, not to actually filter them (see line 169).In
/bgee-core/src/main/resources/R_scripts/topAnat_functions.R
, we need to modify the functionmakeTable
to accept these thresholds as arguments, and use them. Then we need to modify the call to thismakeTable
function.@jwollbrett: do you feel like making this change? I guess it affects the R package as well. If you do make the change in the Java app, you need to checkout from branch
archive_common_bgee_v13_and_later
, since this problem also affects Bgee 13.(I don't think it is absolutely necessary for the release, as the bug is there since a long time I think)
The text was updated successfully, but these errors were encountered: