Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholds p-value and number of significant nodes not taken into account in TopAnat #180

Open
fbastian opened this issue May 26, 2020 · 2 comments
Assignees

Comments

@fbastian
Copy link
Member

In GitLab by @fbastian on Feb 13, 2018, 13:39

In org.bgee.model.topanat.TopAnatRManager, see lines 189-191 in develop branch: p-value and number of significant nodes are taken into account to count the results, not to actually filter them (see line 169).

In /bgee-core/src/main/resources/R_scripts/topAnat_functions.R, we need to modify the function makeTable to accept these thresholds as arguments, and use them. Then we need to modify the call to this makeTable function.

@jwollbrett: do you feel like making this change? I guess it affects the R package as well. If you do make the change in the Java app, you need to checkout from branch archive_common_bgee_v13_and_later, since this problem also affects Bgee 13.
(I don't think it is absolutely necessary for the release, as the bug is there since a long time I think)

@fbastian
Copy link
Member Author

In GitLab by @jwollbrett on Feb 15, 2018, 12:04

assigned to @jwollbrett

@fbastian
Copy link
Member Author

In GitLab by @jwollbrett on Aug 30, 2018, 17:24

mentioned in commit 9b29945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants