Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White border on sides of search bar inside a note with dark mode #24

Closed
kryoqa opened this issue Dec 19, 2024 · 2 comments
Closed

White border on sides of search bar inside a note with dark mode #24

kryoqa opened this issue Dec 19, 2024 · 2 comments
Labels
android The issue is android-specific. bug Something isn't working iOS The issue is iOS-specific. phone The issue only arises on phones. tablet The issue only arises on tablets.

Comments

@kryoqa
Copy link

kryoqa commented Dec 19, 2024

Describe the bug
White borders appear on both sides of search bar inside a note with dark mode enabled

To Reproduce
Steps to reproduce the behavior:

  1. Open Beaver Pocket
  2. Click on an existing note/ Create a new note
  3. Click on search button at the top right of a note
  4. Note search bar opens with white border on both ends

Expected behavior
The search bar should have dark borders or look similar to the main search option

Screenshots
Screenshot_20241219-172311

Smartphone (please complete the following information):

  • OS: Android 14
  • Version [1.3.0]
@kryoqa
Copy link
Author

kryoqa commented Dec 19, 2024

Clicking on the search button doesn't open keyboard, should I create a different issue for this ?
Keyboard - Heliboard

@Daniele-rolli
Copy link
Member

Thanks for your feedback! I'll address all three issues here since you opened them.

Regarding the border and autofocus issue, I’ve found and fixed it, I'll be pushing a commit ASAP. For #25, I’ll look into Google’s documentation. However, I’m not very familiar with Android or its design principles, so I’ll do my best.

As for #23, the themes are different because the components are different. The screenshots show components that use native Android elements, whereas the menu for adding a label or linking a note was custom written for that purpose.

Thanks for contributing to the project!

Daniele-rolli added a commit that referenced this issue Dec 20, 2024
- Share as PDF and .bea
- Custom icon (🍎)
- Fixed issues #24 #21 #20
- Design improvements in dialogs
- Merge and split tables
- Improved search
- Replaced Focus mode with reader mode
@Daniele-rolli Daniele-rolli added bug Something isn't working android The issue is android-specific. iOS The issue is iOS-specific. tablet The issue only arises on tablets. phone The issue only arises on phones. labels Dec 20, 2024
@Daniele-rolli Daniele-rolli moved this to 🎉 Done in 🚚 Beaver's Roadmap Dec 20, 2024
@Daniele-rolli Daniele-rolli closed this as completed by moving to 🎉 Done in 🚚 Beaver's Roadmap Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android The issue is android-specific. bug Something isn't working iOS The issue is iOS-specific. phone The issue only arises on phones. tablet The issue only arises on tablets.
Projects
Status: 🎉 Done
Development

No branches or pull requests

2 participants