Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Professor endpoints #63

Open
Kn99HN opened this issue May 19, 2020 · 6 comments
Open

Professor endpoints #63

Kn99HN opened this issue May 19, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@Kn99HN
Copy link
Member

Kn99HN commented May 19, 2020

It would be nice if we have an endpoints for professors with their ratings, reviews and classes taught. What do you think?

Advantages

  • This would let users have access to more interesting data. The ability to display professors' rating and reviews would be nice when browsing courses.

Disadvantages

  • Adding to the complexity of the codebase
  • Requiring Schema restructure
@Kn99HN Kn99HN added the enhancement New feature or request label May 20, 2020
@A1Liu
Copy link
Collaborator

A1Liu commented May 22, 2020

Lets do it.

@Kn99HN Kn99HN added the good first issue Good for newcomers label May 22, 2020
@A1Liu
Copy link
Collaborator

A1Liu commented Jul 13, 2020

I'm thinking that there are 2 possible use cases:

  1. A user wants to find classes associated with a specific professor
  2. A user wants to find the reviews of a specific professor

I think anything beyond these 2 use cases (i.e. courses over time, full registry of instructors, etc.) is a little overkill. We might be able to provide some extra features as extensions to the 2 functionalities above, but I'm not sure we should go any further than that.

@Kn99HN
Copy link
Member Author

Kn99HN commented Jul 13, 2020

Yeah. I think we should just go with the base case for now. @svasandani feel free to work on this endpoint!

@svasandani
Copy link
Contributor

I think this makes sense. How would users query this endpoint? Right now I think the name would make the most send, but then we should consider serving a full list of instructor names so that client apps can search through it and offer suggestions (it's hard to get the exact name right the first try).

Alternatively, we could handle the searching by ourselves, and have string queries return an array of professor names and IDs that match the search term, and have ID queries return the instructor data. This approach would also be capable of handling the duplicate instructors before we solve that issue.

Let me know which approach you think is best.

@A1Liu
Copy link
Collaborator

A1Liu commented Jul 14, 2020

I think we should definitely go with the searching ourselves option. We'd need to add another field to the instructors table, but that's no biggie.

@A1Liu A1Liu removed the good first issue Good for newcomers label Jan 29, 2022
@Kn99HN
Copy link
Member Author

Kn99HN commented Jan 31, 2022

No need for support for RMP. This can easily be done with their API. We just need a basic professor endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants