Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Background image of welcome notices is missing on Simple sites #98150

Closed
mmtr opened this issue Jan 9, 2025 · 6 comments
Assignees
Labels
[Experiment] AI labels added [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Image CDN Speed-up delivery of images on your site thanks to our image CDN. Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Pri] High Address as soon as possible after BLOCKER issues Remove Duplicate Views [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug

Comments

@mmtr
Copy link
Member

mmtr commented Jan 9, 2025

Looks like the CDN used by WPCOM Simple sites is affecting the way we inject the background image to the welcome notices.

Image

For reference, this is how the notice should look (note the repeated + icon in the background):

Image
@mmtr mmtr added [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug Remove Duplicate Views labels Jan 9, 2025
@github-actions github-actions bot added [Status] Escalated to Product Ambassadors [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Customizer The site customizer for traditional, non-block themes. [Feature] Image CDN Speed-up delivery of images on your site thanks to our image CDN. labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

OpenAI suggested the following labels for this issue:

  • [Feature Group] Appearance & Themes: The issue relates to the visual aspects of the site, specifically the background image of the welcome notices.
  • [Feature] Image CDN: The problem is related to how the CDN is impacting the delivery of images, which directly affects the appearance of welcome notices.
  • [Feature] Customizer: The issue may involve customizations that should reflect properly, including background images, that are not functioning as intended.

@matticbot matticbot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jan 9, 2025
@agrullon95 agrullon95 self-assigned this Jan 13, 2025
@agrullon95
Copy link
Contributor

I'm able to replicate this on my Simple Site. This may be related to how the image was originally set up in the CDN. I'll take a look into this.

Image

@agrullon95
Copy link
Contributor

agrullon95 commented Jan 13, 2025

@mmtr - I added the background image to WPCOM CDN (169915-ghe-Automattic/wpcom) and created a jetpack PR to use the new path: Automattic/jetpack#40983

@agrullon95 agrullon95 moved this from Needs Triage to Needs Review in Automattic Prioritization: The One Board ™ Jan 13, 2025
@mmtr
Copy link
Member Author

mmtr commented Jan 13, 2025

Thanks @agrullon95! This was not intended to be a Groundskeeping bug (since it's not affecting users yet), but thank you for fixing this!

@agrullon95
Copy link
Contributor

All good 👍 I just merged the jetpack PR. Feel free to close when you can.

@mmtr
Copy link
Member Author

mmtr commented Jan 14, 2025

Thank you @agrullon95!

@mmtr mmtr closed this as completed Jan 14, 2025
@agrullon95 agrullon95 added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Image CDN Speed-up delivery of images on your site thanks to our image CDN. Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Pri] High Address as soon as possible after BLOCKER issues Remove Duplicate Views [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug
Development

No branches or pull requests

3 participants