Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the design picker in front of the plans step #97208

Closed
p-jackson opened this issue Dec 8, 2024 · 5 comments
Closed

Move the design picker in front of the plans step #97208

p-jackson opened this issue Dec 8, 2024 · 5 comments
Assignees

Comments

@p-jackson
Copy link
Member

Details

This should be implemented behind the onboarding/goals-first feature flag

Checklist

  • [ ]
  • [ ]

Related

No response

Copy link

github-actions bot commented Dec 8, 2024

This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a [Type], a [Feature], and a [Pri] label?

@p-jackson
Copy link
Member Author

WIP #97383

@candy02058912
Copy link
Contributor

Where we are currently:

We've merged

meaning that the design picker is showing at the right position and won't be duplicated when we redirect to the /site-setup flow.

What is still not working

  • styleVariation and globalStyles are not persisted on site creation

Currently, we cannot move forward if we select a Paid theme or Premium styles with what has been merged.
To pass the modal during testing, we can use this snippet from @zaguiini #97548

Not part of this Issue

For the modal that needs to be removed, it will be part of #97535

@paulopmt1
Copy link
Contributor

we cannot move forward if we select a Paid theme or Premium styles
For the modal that needs to be removed, it will be part of #97535

This will be addressed in this task, which I'm working on. If it takes too much time I may land that diff (implemented in a draft here) to allow us test it with premium themes.

styleVariation and globalStyles are not persisted on site creation

To help with clear goals for each task, I'm moving this to a new task and closing this one, since we already reached its goal.

@paulopmt1
Copy link
Contributor

we cannot move forward if we select a Paid theme or Premium styles

Solution is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants