Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White-labeled plugin: Migration started email does not include source site URL #94340

Closed
sixhours opened this issue Sep 9, 2024 · 3 comments
Closed
Assignees

Comments

@sixhours
Copy link
Contributor

sixhours commented Sep 9, 2024

Working on a migration from a fresh Jurassic Ninja source site, I noticed the site's source URL isn't included in the migration started email:

Image

I'm not sure if this is intentional or if there's an extra space where there shouldn't be one. Needs further investigation.

@sixhours sixhours changed the title White-labeled plugin: Migration started email does not include source site title White-labeled plugin: Migration started email does not include source site URL Sep 9, 2024
@sixhours
Copy link
Contributor Author

sixhours commented Sep 9, 2024

In the previewer, it looks like this:

Image

It seems like we're not getting the source site URL in some instances.

@sixhours
Copy link
Contributor Author

Minor fix for this in D160993-code although I don't know why we don't get the source site 🤔 Is it not always available when you do a migration manually?

@sixhours sixhours self-assigned this Sep 10, 2024
@sixhours
Copy link
Contributor Author

Aha, looking into the code, we acknowledge the fact that there won't always be a source site URL, so the formatting fix in the email should be good enough. Calling this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant