Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text: Remove overridden underline format #94243

Closed
ntsekouras opened this issue Sep 5, 2024 · 0 comments · Fixed by #94244
Closed

Rich Text: Remove overridden underline format #94243

ntsekouras opened this issue Sep 5, 2024 · 0 comments · Fixed by #94244
Assignees
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ntsekouras
Copy link
Member

Currently the underline format is overridden from core in order to add an option in block's toolbar formats dropdown.
Screenshot 2024-09-05 at 3 51 52 PM

In core this button (alongside with the justify one) were removed years ago. TLDR;

Underline - It introduces a potentially bad user experience issue: readers confusing the underline text with a link. Underlined text is broadly interpreted as web links.

Additionally, right now is buggy, because it doesn't handle the shortcuts for it (Command + U).

I would suggest to stop overriding the format and align with core.

Steps to reproduce

  1. Open the post editor and insert some text in a paragraph
  2. Open the formats dropdown in the block's toolbar
  3. Observe the Underline format.
@ntsekouras ntsekouras added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Post/Page Editor The editor for editing posts and pages. labels Sep 5, 2024
@ntsekouras ntsekouras self-assigned this Sep 5, 2024
@github-actions github-actions bot added the [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. label Sep 5, 2024
@Copons Copons moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 5, 2024
@Copons Copons added [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. and removed [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

2 participants