Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: remove language checks on site-migrations-credential step #94237

Closed
andres-blanco opened this issue Sep 5, 2024 · 3 comments
Closed

Cleanup: remove language checks on site-migrations-credential step #94237

andres-blanco opened this issue Sep 5, 2024 · 3 comments
Assignees
@valterlorran

Comments

@andres-blanco
Copy link
Contributor

andres-blanco commented Sep 5, 2024 •
edited
Loading

In this PR language checks were added to prevent showing a mixed language UI.

Once translations are in we should remove those checks to keep the code clean.
@andres-blanco andres-blanco mentioned this issue Sep 5, 2024
Merged
7 tasks
@valterlorran
Copy link
Contributor

Oh! Thanks for creating this issue @andres-blanco!

@valterlorran valterlorran self-assigned this Sep 10, 2024
@valterlorran
Copy link
Contributor

We are tackling this issue here: #94337

@andres-blanco
Copy link
Contributor Author

Closed by #94337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valterlorran valterlorran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andres-blanco @valterlorran