Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Pay / Apple Pay icon alignment has been lost in checkout #94123

Closed
sirbrillig opened this issue Sep 2, 2024 · 2 comments
Closed

Google Pay / Apple Pay icon alignment has been lost in checkout #94123

sirbrillig opened this issue Sep 2, 2024 · 2 comments
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sirbrillig
Copy link
Member

sirbrillig commented Sep 2, 2024

The Google Pay and Apple Pay icons in checkout's payment method list have lost their right alignment recently somehow.

Screenshot 2024-09-02 at 6 53 26 PM Screenshot 2024-09-02 at 6 58 28 PM

Possibly related to #94007 or #93932

To reproduce:

  • Visit wordpress.com and add a product to your cart (eg: a plan upgrade).
  • Visit checkout (you should end up there automatically).
  • Make sure your browser is configured to allow either Apple Pay or Google Pay (for Apple Pay you must have Safari and Apple Pay enabled with a card in your wallet, for Google Pay you must have Chrome with Google Pay enabled and a card in your wallet).
  • Click through to the end of checkout and view the payment method options (if a payment method is already selected, you may need to click "edit" on the payment method step).
  • Examine the alignment of the Google Pay or Apple Pay icon relative to the other icons in the list and notice that it is smooshed against the text on the left side rather than right-aligned.
@sirbrillig sirbrillig changed the title Google Pay icon alignment has been lost in checkout Google Pay / Apple Pay icon alignment has been lost in checkout Sep 2, 2024
@sirbrillig sirbrillig added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Low Address when resources are available. [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Sep 2, 2024
@michaeldcain michaeldcain added [Pri] Normal Schedule for the next available opportuinity. and removed [Pri] Low Address when resources are available. labels Sep 3, 2024
@michaeldcain
Copy link
Member

@jjchrisdiehl can you take a look at this. It seems to be a regression from the co-badge work.

@michaeldcain
Copy link
Member

Closed by #94159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

3 participants
@michaeldcain @sirbrillig and others