Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a textarea input on the MC tool receive our QuickForget JSON #94111

Closed
andres-blanco opened this issue Sep 2, 2024 · 4 comments
Closed
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".

Comments

@andres-blanco
Copy link
Contributor

andres-blanco commented Sep 2, 2024

Right now we are storing the created credentials in a escaped JSON object. This is troublesome to copy and paste the URLs and probably will break passwords if they contain a forward slash.

A better alternative would be filtering the URL (https://www.php.net/manual/en/filter.constants.php#constant.filter-validate-url) and then storing the JSON unescaped.

This was raised here: pdtkmj-2RI-p2#comment-5519

Copy link

github-actions bot commented Sep 2, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • pdtkmj-2RI-p2#comment-5519

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 2, 2024
@valterlorran
Copy link
Contributor

@andres-blanco and I just synced, and we discussed that we should be careful "unescaping" the JSON because if the user inputs quotes, it may cause the JSON to be unreadable. We decided to add a textarea input on the MC Tool, which will unescape the JSON automatically and auto-fill the information for the HEs.

@valterlorran valterlorran changed the title Better formatting of the QuickForget secret Add a textarea input on the MC tool receive our QuickForget JSON Sep 4, 2024
@valterlorran valterlorran self-assigned this Sep 6, 2024
@valterlorran
Copy link
Contributor

valterlorran commented Sep 6, 2024

I'm addressing this issue here 157960-ghe-Automattic/missioncontrol

@valterlorran
Copy link
Contributor

Closing this as 157960-ghe-Automattic/missioncontrol was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".
Projects
None yet
Development

No branches or pull requests

2 participants