Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the masterbar notification icon in the Reader Notifications page does nothing #94019

Closed
taipeicoder opened this issue Aug 29, 2024 · 10 comments
Labels
[Pri] Normal Schedule for the next available opportuinity.

Comments

@taipeicoder
Copy link
Contributor

Description

See pbxlJb-6dR-p2, 06:15

The notification icon on the masterbar seems selected, and is unresponsive when clicked.

Image

@mrfoxtalbot
Copy link

I can replicate this. Once you are in https://wordpress.com/read/notifications, clicking on the "bell" icon in the Admin bar has no effect.

@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Aug 29, 2024
@mrfoxtalbot
Copy link

@taipeicoder, I have added this to the Logica Flows board. Please lñet me know if this is not correct.

@mrfoxtalbot mrfoxtalbot added the [Pri] Normal Schedule for the next available opportuinity. label Aug 29, 2024
@taipeicoder
Copy link
Contributor Author

@mrfoxtalbot as I understand it, new Fit and Finish issues from walkthroughs will be triaged on The One Board while the tasks on the Logical Flow board will eventually move there as well. So I'd say having them on The One Board should be enough, no need to add them to the Logical Flows one as well.

@javierarce
Copy link

javierarce commented Aug 30, 2024

Since the notifications feature is accessible at all times from the masterbar, why don't we remove the item from the sidebar?

This would solve the current issue and we'd get rid of the awkwardness in appearance and position of this column when opened from the reader's sidebar.

@davemart-in
Copy link
Contributor

We can't remove the notifications section in the reader sidebar. It's the fallback for when 3rd party cookies fail.

@davemart-in
Copy link
Contributor

@taipeicoder @mrfoxtalbot can you please clarify what you expect to happen?

@davemart-in davemart-in moved this from Triaged to Needs more details in Automattic Prioritization: The One Board ™ Aug 30, 2024
@javierarce
Copy link

We can't remove the notifications section in the reader sidebar. It's the fallback for when 3rd party cookies fail.

But in that case, why can we show the notifications on the Reader? 🤔 Sorry, I don't understand the relationship between the cookies and the masterbar 😅

@davemart-in
Copy link
Contributor

davemart-in commented Aug 30, 2024

This is an issue because of custom domains. When a site has a custom domain and they click to see notifications, depending on their browser security settings, it might error out.

Put another way, the notifications panel that slides in may not work for sites with custom domains, depending on the security settings that you have set in your browser.

We try and recognize when this happens and instead redirect you to https://wordpress.com/read/notifications (instead of showing you a notifications panel with zero notifications).

https://wordpress.com/read/notifications works across all browsers because it uses our domain (not a custom domain).

Does that help add clarity?

@javierarce
Copy link

Yes, thanks a lot for the explanation, @davemart-in.

@davemart-in
Copy link
Contributor

I'm going to close this issue out. From my perspective, I don't think we should trigger the notifications panel to open, when you're already on the dedicated notifications screen within reader. My guess is that something would blow up. :-)

@github-project-automation github-project-automation bot moved this from Needs more details to Done 🎉 in Automattic Prioritization: The One Board ™ Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Schedule for the next available opportuinity.
Development

No branches or pull requests

4 participants